From: Zander Brown <zbrown@gnome.org>
Date: Fri, 2 Apr 2021 03:39:31 +0000 (+0100)
Subject: remoteSearch: Fetch enabled/disabled list once
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~78
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=2f70e524c33db55a3c33c0a4bb02eaee093d8454;p=gnome-shell.git

remoteSearch: Fetch enabled/disabled list once

GLib should be caching the values but it seems unnecessary to fetch
and marshal what should be the same lists N times instead of just once

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1791>
---

diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js
index 77ad317e1..137516bdc 100644
--- a/js/ui/remoteSearch.js
+++ b/js/ui/remoteSearch.js
@@ -142,16 +142,16 @@ function loadRemoteSearchProviders(searchSettings, callback) {
     // Special case gnome-control-center to be always active and always first
     sortOrder.unshift('gnome-control-center.desktop');
 
+    const disabled = searchSettings.get_strv('disabled');
+    const enabled = searchSettings.get_strv('enabled');
+
     loadedProviders = loadedProviders.filter(provider => {
         let appId = provider.appInfo.get_id();
 
-        if (provider.defaultEnabled) {
-            let disabled = searchSettings.get_strv('disabled');
+        if (provider.defaultEnabled)
             return !disabled.includes(appId);
-        } else {
-            let enabled = searchSettings.get_strv('enabled');
+        else
             return enabled.includes(appId);
-        }
     });
 
     loadedProviders.sort((providerA, providerB) => {